Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: return error instead of panic when ArtifactService is nil (#283) #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JEETDESAI25 wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

fix: return error instead of panic when ArtifactService is nil (#283) #430

JEETDESAI25 wants to merge 2 commits into from
+53 −8

Conversation

@JEETDESAI25
Copy link

@JEETDESAI25 JEETDESAI25 commented Dec 18, 2025 •
edited
Loading

Addressing issue: #283

Fixes a nil pointer dereference panic in loadartifactstool that occurred when the tool was used without configuring an ArtifactService in the Runner. The tool now returns ErrArtifactServiceNotInitialized instead of panicking.

Changes:

  • Added ErrArtifactServiceNotInitialized error in loadartifactstool
  • Added nil check in ProcessRequest()
  • Fixed context wrappers to return nil when underlying ArtifactService is nil

Test: Added TestLoadArtifactsTool_ProcessRequest_NilArtifactService.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 18, 2025

Summary of Changes

Hello @JEETDESAI25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the system by preventing a potential nil pointer dereference panic in the loadartifactstool. Previously, if the ArtifactService was not initialized, the tool would crash. Now, it will instead return a clear error, improving the stability and predictability of the application. The changes involve adding explicit nil checks and adjusting context initialization to correctly propagate the absence of an artifact service.

Highlights

  • Error Handling: The loadartifactstool now returns a specific error, ErrArtifactServiceNotInitialized, instead of panicking when the ArtifactService is not configured.
  • Nil Checks: Introduced nil checks in ProcessRequest() within loadartifactstool to gracefully handle uninitialized artifact services.
  • Context Wrappers: Modified internal context wrappers (callbackContext and toolContext) to ensure their Artifacts() methods return nil if the underlying ArtifactService is not present.
  • Testing: A new test case, TestLoadArtifactsTool_ProcessRequest_NilArtifactService, has been added to validate the new error handling behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 18, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a potential nil pointer dereference in loadartifactstool when an ArtifactService is not configured. The changes correctly add nil checks in the context wrappers and in the tool's ProcessRequest method to return a specific error instead of panicking. A new test case has been added to verify this fix. The changes are well-implemented and effectively resolve the issue. I have one minor suggestion to simplify the error checking in the new test.

tool/loadartifactstool/load_artifacts_tool_test.go Outdated Show resolved Hide resolved
@JEETDESAI25 @gemini-code-assist
Update tool/loadartifactstool/load_artifacts_tool_test.go
cf70a17 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JEETDESAI25
Morty Proxy This is a proxified and sanitized view of the page, visit original site.