Fix test cases failure due to the time zone #429
Conversation
Currently, the following test case is failed on my side due to using `time.UnixMicro`
to truncate the precision:
```shell
service_test.go:363: Get session events mismatch: (-want +got):
database.events{
&{
LLMResponse: {},
- ID: "4",
+ ID: "3",
- Timestamp: s"0001-01-01 00:00:00.000004 +0000 UTC",
+ Timestamp: s"0001-01-01 08:05:43.000003 +0805 +0805",
InvocationID: "",
Branch: "",
... // 3 identical fields
},
```
The root cause should be caused by the convertion of the zero time. To
work around this, just simply use the time.Now() as the timestamp.
Summary of ChangesHello @git-hulk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and fixes a specific issue within the test suite where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a test failure caused by using a zero time.Time value, which led to precision and timezone issues. The fix replaces the zero time with time.Now() to provide a valid timestamp base. This correctly resolves the test failure. I have one suggestion to further improve the test's reliability by using a fixed timestamp instead of time.Now(), which will make the test fully deterministic and easier to debug in the future.
|
After diving deep, I found the root cause is that SQLite only supports the ISO-8601 string comparison, see stackoverflow. So, when storing and filtering rows with different time zones, it might retrieve the wrong value. |
|
Thanks for checking that! But will this issue affect actual SQLite based session service? |
I think it only affects test cases that use |
Currently, the following test case is failing on my side due to using
time.UnixMicroto truncate the precision:service_test.go:363: Get session events mismatch: (-want +got): database.events{ &{ LLMResponse: {}, - ID: "4", + ID: "3", - Timestamp: s"0001-01-01 00:00:00.000004 +0000 UTC", + Timestamp: s"0001-01-01 08:05:43.000003 +0805 +0805", InvocationID: "", Branch: "", ... // 3 identical fields },The root cause should be
time.UnixMicrowill change the time.Time to the local timezone. To work around this, use the fixed time with the local timezone instead of UTC.It's related to the change in PR #414.