Refactor server logic #921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a generic tracing package to log messages to output if target is enabled.
Use go-git backend to serve the file transport instead of relying on the git binary to do so. Replace old ioutil.Pipe with std io.Pipe. Add a clone command Trace pktline encoder/scanner calls
pjbgf
reviewed
Nov 13, 2023
Comment on lines
+5
to
+6
| replace github.com/go-git/go-git/v5 => ../../ | ||
|
|
There was a problem hiding this comment.
Suggested change
| replace github.com/go-git/go-git/v5 => ../../ |
|
|
||
| "github.com/go-git/go-git/v5/internal/repository" |
There was a problem hiding this comment.
As this change would be done within a minor release, let's also keep the previous behaviour (marked as deprecated) within plumbing/transport/file (say in client_git.go), so that users can revert back to via InstallProtocol - in case our implementation introduces some regression.
|
Superseded by #938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use go-git backend to serve the file transport instead of relying on the
git binary to do so.
Replace old ioutil.Pipe with std io.Pipe.
Add a clone command
Trace pktline encoder/scanner calls