Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support x509 and SSH key signed commits and tags #400

Copy link
Copy link
Open
@hiddeco

Description

@hiddeco
Issue body actions

As git started to support SSH signing since yesterday, I am polling interest to start supporting this in go-git. While we are at it, it would likely be beneficial to add support for x509 signed commits as well (possible using e.g. smimesign).

Changes required, based on a quick analysis:

The latter seems to be the hardest part, as the current contract assumes an armored key ring. One way to make this backwards compatible would be to just assume the string data is the correct data to verify the type, but I am open to alternatives.

lafriks, bensallen, melvincarvalho, stefanprodan, pjbgf and 23 moremelvincarvalho, pjbgf, dakky and baksetercx

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or requestno-autocloseIssues/PRs to be ignored by stale botIssues/PRs to be ignored by stale bot

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.