refactor: clean up number_to_string and add SSL test coverage#401
Open
MarcosViniicius wants to merge 1 commit intoglobocom:masterglobocom/m3u8:masterfrom
Open
refactor: clean up number_to_string and add SSL test coverage#401MarcosViniicius wants to merge 1 commit intoglobocom:masterglobocom/m3u8:masterfrom
MarcosViniicius wants to merge 1 commit intoglobocom:masterglobocom/m3u8:masterfrom
Conversation
- Refactor number_to_string function to reduce code complexity - Add new test case: test_download_with_ssl_verification_disabled This test verifies download behavior when SSL verification is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aqui está a descrição organizada:
Description
This pull request introduces code refactoring and adds a new unit test to improve test coverage for SSL verification handling in HTTP downloads.
Testing improvements
test_download_with_ssl_verification_disabledintests/test_http_client.pyto verify that downloading with SSL verification disabled works as expected.Code cleanup
number_to_stringfunction inm3u8/model.pyfor improved readability by reducing code complexity.Screenshots
Before refactoring:
After refactoring:
Test coverage - Before (92%):
Test coverage - After (100%):
All tests passing ✓