Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d15f891

Browse filesBrowse files
EliahKaganEliahKagan
committed
macOS needs even more extra time in test_blocking_lock_file
As seen in: https://github.com/EliahKagan/GitPython/actions/runs/7056321920/attempts/1 Usually an extra_time of 0.12 (6x) is sufficient for both Windows and macOS, but sometimes macOS needs even more, so this increases it to 0.18 (9x) for macOS.
1 parent c16e4f3 commit d15f891
Copy full SHA for d15f891

File tree

1 file changed

+4
-2
lines changed
Filter options

1 file changed

+4
-2
lines changed

‎test/test_util.py

Copy file name to clipboardExpand all lines: test/test_util.py
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,10 @@ def test_blocking_lock_file(self):
397397
self.assertRaises(IOError, wait_lock._obtain_lock)
398398
elapsed = time.time() - start
399399
extra_time = 0.02
400-
if os.name == "nt" or sys.platform == "cygwin" or sys.platform == "darwin":
401-
extra_time *= 6 # NOTE: Indeterministic failures without this...
400+
if os.name == "nt" or sys.platform == "cygwin":
401+
extra_time *= 6 # Without this, we get indeterministic failures on Windows.
402+
elif sys.platform == "darwin":
403+
extra_time *= 9 # The situation on macOS is similar, but with more delay.
402404
self.assertLess(elapsed, wait_time + extra_time)
403405

404406
def test_user_id(self):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.