Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a11b89a

Browse filesBrowse files
EliahKaganEliahKagan
committed
Clarify why GIT_PYTHON_GIT_EXECUTABLE may be set on failure
This clarifies the comment that explains the significance of setting the Git.GIT_PYTHON_GIT_EXECUTABLE attribute when running Git failed but the attribute wasn't set before. This happens in the code path in Git.refresh where has_git is False and old_git is None, provided the refresh mode doesn't call for the initial refresh to raise an exception on failure. It was previously described in terms of a "first" and "second" import, but as discussed in #1804, the rationale and effect were not altogether clear.
1 parent d28c20b commit a11b89a
Copy full SHA for a11b89a

File tree

Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed

‎git/cmd.py

Copy file name to clipboardExpand all lines: git/cmd.py
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -475,9 +475,10 @@ def refresh(cls, path: Union[None, PathLike] = None) -> bool:
475475
)
476476
raise ImportError(err)
477477

478-
# We get here if this was the init refresh and the refresh mode was not
479-
# error. Go ahead and set the GIT_PYTHON_GIT_EXECUTABLE such that we
480-
# discern the difference between a first import and a second import.
478+
# We get here if this was the initial refresh and the refresh mode was
479+
# not error. Go ahead and set the GIT_PYTHON_GIT_EXECUTABLE such that we
480+
# discern the the difference between the first refresh at import time
481+
# and subsequent calls to refresh.
481482
cls.GIT_PYTHON_GIT_EXECUTABLE = cls.git_exec_name
482483
else:
483484
# After the first refresh (when GIT_PYTHON_GIT_EXECUTABLE is no longer

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.