Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor: Repository.move filters nodes instead of deleting their sha #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AurelioDeRosa wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

refactor: Repository.move filters nodes instead of deleting their sha #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions 6 lib/Repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,11 +588,9 @@ class Repository extends Requestable {
if (ref.path === oldPath) {
ref.path = newPath;
}
if (ref.type === 'tree') {
delete ref.sha;
}
return ref;
});
})
.filter((ref) => ref.type !== 'tree');
Copy link
Member

@clayreimann clayreimann Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add whitespace for clarity.

Copy link
Member Author

@AurelioDeRosa AurelioDeRosa Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Where do you want to place it?

Copy link
Member

@clayreimann clayreimann Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

between this line and the return

return this.createTree(newTree);
})
.then(({data: tree}) => this.commit(oldSha, tree.sha, `Renamed '${oldPath}' to '${newPath}'`))
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.