upgrade to v3 #122
Closed
upgrade to v3 #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1+ |
Member
|
Hi @malei0311 — could you please rebase this so it's current on master, and then write some unit tests for this? Will happily merge after, probably even bumping the minor version. Thanks! |
Member
|
Closed in error; reopening. |
e746e5d to
6f04f13
Compare
Member
|
This is currently in the repo, so I guess that at some point it was integrated. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade the repo to v3 && "// -------+" the line end up with a plus sign has been confirmed same width v3