Optionally Print Issue and Pull Requests Body #616
Conversation
|
(This change is one of those that would be much simpler to do when we have custom templates instead - so that the user would pick what to output themselves, using that.) |
Changelog docker file updated to use a fork with the pull request „Optionally Print Issue and Pull Requests Body“ (github-changelog-generator/github-changelog-generator#616) which is not yet merged in the original repo.
Changelog docker file updated to use a fork with the pull request „Optionally Print Issue and Pull Requests Body“ (github-changelog-generator/github-changelog-generator#616) which is not yet merged in the original repo.
|
@ArtieReus Looking forward to this being merged in--I was about to code up the feature myself. :) |
|
@lindydonna still waiting for any action over 1 month. If you want to use it before it gets merged you can get it from my fork: https://github.com/ArtieReus/github-changelog-generator/tree/include_body_issue |
|
@ArtieReus I tried to use it from your fork, but I'm running into strange problems with master trying to run on MacOS. Any ideas on #629? I ended up backporting your change to 1.4.3, but it's a horrible hack! |
spec/unit/generator/entry_spec.rb
Outdated
| @@ -43,27 +45,28 @@ def default_sections | ||
| project: "repo", | ||
| bug_labels: ["bug"], | ||
| enhancement_labels: ["enhancement"], | ||
| breaking_labels: ["breaking"] | ||
| breaking_labels: ["breaking"], | ||
| issue_line_body: true |
There was a problem hiding this comment.
Everything is looking good. Just would like to leave default behavior as is, without a body by default.
spec/unit/generator/entry_spec.rb
Outdated
| @@ -43,27 +45,28 @@ def default_sections | ||
| project: "repo", | ||
| bug_labels: ["bug"], | ||
| enhancement_labels: ["enhancement"], | ||
| breaking_labels: ["breaking"] | ||
| breaking_labels: ["breaking"], | ||
| issue_line_body: true |
There was a problem hiding this comment.
- please, add relevant option there:
|
Happy to hear that. Applied changes. |
|
Anything new on this PR? |
|
Thanks, @ArtieReus |
|
Thanks @ArtieReus |
|
Merged master into the branch. Notice that I changed Thx |
|
Instead of merging new commits can you please just rebase you work on master? Thanks |
476871a to
882ee0c
Compare
|
Done! |
|
I'll take this into master, now. |
This commit adds the possibility by configuration to enhance the issues and pull requests lines printed in the changelog with the first paragraph of body. Empty bodies will be ignore so that the default behaviour stays as it is.
The here proposed enhancement would look like this:
Fixed bugs:
This is the body of the issue. It will just copy the first paragraph of the body.
Merged pull requests:
This is the body of the pull request. It will just copy the first paragraph of the body.
Having this pull request as an example this will be the difference adding "issue_line_body" in your configuration:
Optionally Print Issue and Pull Requests Body #XX (ArtieReus)
Optionally Print Issue and Pull Requests Body #XX (ArtieReus)
This commit adds the possibility by configuration to enhance the issues and pull requests lines printed in the changelog with the first paragraph of body. Empty bodies will be ignore so that the default behaviour stays as it is.