Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Schema Inaccuracy] Pull Request Review Comment position should be nullable #1901

Copy link
Copy link
Open
@bigfootjon

Description

@bigfootjon
Issue body actions

Schema Inaccuracy

For each Pull Request Comment in the API, it has a position field attached. Some comments are not attached to a position so this field is null. The Schema does not reflect this nuance.

Expected

position in Pull Request review comments should be marked as nullable

Reproduction Steps

We have observed this in 2 different APIs, either listing PR review comments or fetching a specific comment:

$ curl https://api.github.com/repos/pytorch/tutorials/pulls/2120/comments
$ curl https://api.github.com/repos/pytorch/tutorials/pulls/comments/1024558033

In both cases, the position field is null:

...
"position": null,
...

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.