Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Hide private instance state#16

Merged
dgraham merged 2 commits into
mastergithub/remote-input-element:masterfrom
private-stategithub/remote-input-element:private-stateCopy head branch name to clipboard
Oct 18, 2019
Merged

Hide private instance state#16
dgraham merged 2 commits into
mastergithub/remote-input-element:masterfrom
private-stategithub/remote-input-element:private-stateCopy head branch name to clipboard

Conversation

@dgraham

@dgraham dgraham commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

Move private instance variables into a WeakMap so they aren't exposed as public API on the element. The private variables are removed from the type declaration file as well.

$ diff dist-master/index.d.ts dist/index.d.ts

<     currentQuery: string | null;
<     debounceInputChange: (event: Event) => void;
<     boundFetchResults: (event: Event) => void;

Move private instance variables into a WeakMap so they aren't exposed as
public API on the element.
@dgraham dgraham requested a review from a team October 18, 2019 17:48
@dgraham dgraham merged commit dff602d into master Oct 18, 2019
@dgraham dgraham deleted the private-state branch October 18, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.