Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

remove merge command#89

Merged
skarim merged 1 commit into
skarim/help-textgithub/gh-stack:skarim/help-textfrom
skarim/rm-mergegithub/gh-stack:skarim/rm-mergeCopy head branch name to clipboard
May 15, 2026
Merged

remove merge command#89
skarim merged 1 commit into
skarim/help-textgithub/gh-stack:skarim/help-textfrom
skarim/rm-mergegithub/gh-stack:skarim/rm-mergeCopy head branch name to clipboard

Conversation

@skarim

@skarim skarim commented May 14, 2026

Copy link
Copy Markdown
Collaborator

Remove merge command

Remove gh stack merge — it was a placeholder that opened the browser rather than performing an actual merge. Merging stacked PRs is done through the GitHub UI. Will re-add once we have the merge API for Stacked PRs up and running.

Changes

  • Delete cmd/merge.go and cmd/merge_test.go
  • Remove merge command registration from cmd/root.go

Stack created with GitHub Stacks CLIGive Feedback 💬

@skarim skarim marked this pull request as ready for review May 14, 2026 22:13
Copilot AI review requested due to automatic review settings May 14, 2026 22:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the placeholder gh stack merge command, which previously only opened the PR in a browser rather than performing an actual merge. The command will be reintroduced once a real merge API for Stacked PRs exists.

Changes:

  • Delete cmd/merge.go and cmd/merge_test.go
  • Unregister the merge subcommand in cmd/root.go and update cmd/root_test.go expectations
  • Remove the gh stack merge section from README.md
Show a summary per file
File Description
cmd/merge.go Deleted placeholder merge command implementation
cmd/merge_test.go Deleted tests for the removed merge command
cmd/root.go Removed registration of MergeCmd from the root command
cmd/root_test.go Updated expected subcommand list to drop "merge"
README.md Removed the gh stack merge documentation section

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 0

@skarim skarim force-pushed the skarim/rm-merge branch 2 times, most recently from 2c85e59 to 35b0889 Compare May 14, 2026 22:24
@skarim skarim force-pushed the skarim/help-text branch from 5882b7d to 9d6e3b7 Compare May 14, 2026 22:55
@skarim skarim force-pushed the skarim/rm-merge branch from 35b0889 to 56eea17 Compare May 14, 2026 22:55
@skarim skarim force-pushed the skarim/rm-merge branch from 56eea17 to 1b43b7e Compare May 15, 2026 14:18
@skarim skarim merged commit 00a9589 into main May 15, 2026
6 checks passed
@skarim skarim deleted the skarim/rm-merge branch May 15, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.