Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

minor docs styling & content updates#48

Merged
skarim merged 4 commits into
skarim/fix-onto-rebasegithub/gh-stack:skarim/fix-onto-rebasefrom
skarim/docs-stylinggithub/gh-stack:skarim/docs-stylingCopy head branch name to clipboard
Apr 20, 2026
Merged

minor docs styling & content updates#48
skarim merged 4 commits into
skarim/fix-onto-rebasegithub/gh-stack:skarim/fix-onto-rebasefrom
skarim/docs-stylinggithub/gh-stack:skarim/docs-stylingCopy head branch name to clipboard

Conversation

@skarim

@skarim skarim commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator
  • Add proper meta tags for social sharing previews
  • Fix stack diagram styling to invert colors properly in Safari dark mode
  • Update favicon
  • Instructions for installing skills using gh skill

Copilot AI review requested due to automatic review settings April 17, 2026 04:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation landing page visuals and improves social-sharing metadata for the Astro/Starlight docs site.

Changes:

  • Replaces the static stack diagram SVG asset usage with an inline StackDiagram Astro component.
  • Adds Open Graph/Twitter meta tags (and updates the site description) for richer link previews.
  • Adds a social card image asset and removes the old stack-diagram.svg file.
Show a summary per file
File Description
docs/src/content/docs/index.mdx Swaps embedded diagram image markup for a reusable StackDiagram component.
docs/src/components/StackDiagram.astro Introduces an inline SVG diagram component with theme-aware styling.
docs/src/assets/stack-diagram.svg Removes the old static SVG asset no longer referenced.
docs/public/github-social-card.jpg Adds a social preview image referenced by OG/Twitter meta tags.
docs/astro.config.mjs Updates site description and adds OG/Twitter metadata tags (and removes robots noindex).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

docs/src/components/StackDiagram.astro:61

  • The wrapper hard-codes text colors (#1f1f1f / #ffffff), but the docs theme already defines --sl-color-text (and switches it by data-theme). Using the theme variable here will keep the SVG aligned with future palette changes and avoid mismatches if additional themes are added.
<style>
  .stack-diagram-wrapper {
    color: #1f1f1f;
  }
  :root[data-theme='dark'] .stack-diagram-wrapper {
    color: #ffffff;
  }
  • Files reviewed: 3/5 changed files
  • Comments generated: 3

Comment thread docs/src/components/StackDiagram.astro
Comment thread docs/astro.config.mjs
Comment thread docs/astro.config.mjs
@skarim skarim force-pushed the skarim/fix-onto-rebase branch from 614f5bd to b4c2af0 Compare April 17, 2026 05:28
@skarim skarim force-pushed the skarim/docs-styling branch from e13e4d0 to 5ee094e Compare April 17, 2026 05:28

@Lukeghenco Lukeghenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢 it.

@skarim skarim changed the title minor docs styling updates minor docs styling & content updates Apr 17, 2026
@skarim skarim merged commit f13e7b9 into main Apr 20, 2026
3 checks passed
@skarim skarim deleted the skarim/docs-styling branch April 20, 2026 14:17
skarim added a commit that referenced this pull request Apr 20, 2026
* udpate meta tags for docs site

* stack diagram styling fixes

* update favicon

* recommend gh skill to install skills file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.