feat(types): add filter-input to HTMLElementTagNameMap#10
Merged
keithamus merged 1 commit intoApr 17, 2023
github:maingithub/filter-input-element:mainfrom
nberlette:feat-tagname-mapnberlette/filter-input-element:feat-tagname-mapCopy head branch name to clipboard
Merged
feat(types): add filter-input to HTMLElementTagNameMap#10keithamus merged 1 commit intogithub:maingithub/filter-input-element:mainfrom nberlette:feat-tagname-mapnberlette/filter-input-element:feat-tagname-mapCopy head branch name to clipboard
filter-input to HTMLElementTagNameMap#10keithamus merged 1 commit into
github:maingithub/filter-input-element:mainfrom
nberlette:feat-tagname-mapnberlette/filter-input-element:feat-tagname-mapCopy head branch name to clipboard
Conversation
Adding `filter-input` to the global `HTMLElementTagNameMap` interface is the type-level equivalent of registering the tag in the global registry. Since it is now recognized as a globally-available element, it enables stronger types when using `<filter-input>` directly, or adding event listeners, etc.
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
keithamus
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
filter-inputto the globalHTMLElementTagNameMapinterface.This is essentially the type-level equivalent of adding the tag to the global registry.
Since it is now a globally-recognized element, it's treated as a first class citizen in
the DOM, receiving full type support when using
<filter-input>directly in your code,or adding event listeners, and so on.