Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update rules for flat config #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Update rules for flat config #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2361e
update rules for flat config
gracepark Jan 6, 2025
75978c8
run prettier
gracepark Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions 7 lib/rules/async-currenttarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@ module.exports = {

create(context) {
const scopeDidWait = new WeakSet()
const sourceCode = context.sourceCode ?? context.getSourceCode()

return {
AwaitExpression() {
scopeDidWait.add(context.getScope())
AwaitExpression(node) {
scopeDidWait.add(sourceCode.getScope ? sourceCode.getScope(node) : context.getScope())
},
MemberExpression(node) {
if (node.property && node.property.name === 'currentTarget') {
let scope = context.getScope()
let scope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope()
while (scope) {
if (scopeDidWait.has(scope)) {
context.report({
Expand Down
7 changes: 4 additions & 3 deletions 7 lib/rules/async-preventdefault.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@ module.exports = {

create(context) {
const scopeDidWait = new WeakSet()
const sourceCode = context.sourceCode ?? context.getSourceCode()

return {
AwaitExpression() {
scopeDidWait.add(context.getScope())
AwaitExpression(node) {
scopeDidWait.add(sourceCode.getScope ? sourceCode.getScope(node) : context.getScope())
},
CallExpression(node) {
if (node.callee.property && node.callee.property.name === 'preventDefault') {
let scope = context.getScope()
let scope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope()
while (scope) {
if (scopeDidWait.has(scope)) {
context.report({
Expand Down
2 changes: 1 addition & 1 deletion 2 lib/rules/filenames-match-regex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ module.exports = {

return {
Program(node) {
const filename = context.getFilename()
const filename = context.filename ?? context.getFilename()
const absoluteFilename = path.resolve(filename)
const parsed = parseFilename(absoluteFilename)
const shouldIgnore = isIgnoredFilename(filename)
Expand Down
2 changes: 1 addition & 1 deletion 2 lib/rules/no-useless-passive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ module.exports = {
if (i === -1) return
const passiveProp = options.properties[i]
const l = options.properties.length
const source = context.getSourceCode()
const source = context.sourceCode ?? context.getSourceCode()
context.report({
node: passiveProp,
message: `"${name.value}" event listener is not cancellable and so \`passive: true\` does nothing.`,
Expand Down
4 changes: 3 additions & 1 deletion 4 test-examples/flat/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ export default [
'github/no-then': 'error',
'github/no-blur': 'error',
'github/async-preventdefault': 'error',
'github/filenames-match-regex': ['error', '^([a-z0-9]+)([A-Z][a-z0-9]+)*$'],
'github/async-currenttarget': 'error',
'github/no-useless-passive': 'error',
'github/filenames-match-regex': 'error',
},
},
]
18 changes: 18 additions & 0 deletions 18 test-examples/flat/src/getAttribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,21 @@ document.addEventListener('click', async function (event) {

event.preventDefault()
})

window.addEventListener(
'scroll',
() => {
console.log('Scroll event fired!')
},
{passive: true},
)

document.addEventListener('click', async function (event) {
// event.currentTarget will be an HTMLElement
const url = event.currentTarget.getAttribute('data-url')
const data = await fetch(url)

// But now, event.currentTarget will be null
const text = event.currentTarget.getAttribute('data-text')
Copy link
Preview

Copilot AI Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event.currentTarget might be null after the await call. Add a null check before accessing getAttribute.

Suggested change
const text = event.currentTarget.getAttribute('data-text')
if (event.currentTarget === null) return;
const text = event.currentTarget.getAttribute('data-text')

Copilot uses AI. Check for mistakes.

Positive FeedbackNegative Feedback
// ...
})
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.