Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c2ea115

Browse filesBrowse files
committed
Use literal prop
1 parent dd3cba1 commit c2ea115
Copy full SHA for c2ea115

File tree

Expand file treeCollapse file tree

1 file changed

+6
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-3
lines changed

‎lib/rules/a11y-no-visually-hidden-interactive-element.js

Copy file name to clipboardExpand all lines: lib/rules/a11y-no-visually-hidden-interactive-element.js
+6-3Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const {getProp, getPropValue} = require('jsx-ast-utils')
1+
const {getProp, getLiteralPropValue} = require('jsx-ast-utils')
22
const {getElementType} = require('../utils/get-element-type')
33
const {generateObjSchema} = require('eslint-plugin-jsx-a11y/lib/util/schemas')
44

@@ -32,9 +32,12 @@ const checkIfInteractiveElement = (context, node) => {
3232
const checkIfVisuallyHiddenAndInteractive = (context, options, node, isParentVisuallyHidden) => {
3333
const {className, componentName} = options
3434
if (node.type === 'JSXElement') {
35-
const classes = getPropValue(getProp(node.openingElement.attributes, 'className'))
35+
const classes = getLiteralPropValue(getProp(node.openingElement.attributes, 'className'))
3636
const isVisuallyHiddenElement = node.openingElement.name.name === componentName
37-
const hasSROnlyClass = typeof classes !== 'undefined' && classes.includes(className)
37+
let hasSROnlyClass = false
38+
if (classes != null) {
39+
hasSROnlyClass = classes.includes(className)
40+
}
3841
let isHidden = false
3942
if (hasSROnlyClass || isVisuallyHiddenElement || !!isParentVisuallyHidden) {
4043
if (checkIfInteractiveElement(context, node)) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.