Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix small typo in aria-label-is-well-formatted.md #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

Fix small typo in aria-label-is-well-formatted.md #67

merged 2 commits into from
Apr 26, 2023

Conversation

theerebuss
Copy link
Contributor

@theerebuss theerebuss commented Apr 24, 2023 •
edited
Loading

Noticed a small typo in the anchor examples of the docs:

<a href="https://github.com/shopify/erb-lint"> aria-label="Shopify/erb-lint on GitHub"></a>

However, the anchor is closed before the aria-label attribute, so I changed it to:

<a href="https://github.com/shopify/erb-lint" aria-label="Shopify/erb-lint on GitHub"></a>

@theerebuss theerebuss changed the title Fix typo in aria-label-is-well-formatted.md Fix small typo in aria-label-is-well-formatted.md Apr 24, 2023
@theerebuss theerebuss marked this pull request as ready for review April 24, 2023 21:23
@theerebuss theerebuss requested a review from a team as a code owner April 24, 2023 21:23
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

lindseywild
lindseywild approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@lindseywild lindseywild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@theerebuss theerebuss merged commit df143ff into main Apr 26, 2023
@theerebuss theerebuss deleted the typo-fix branch April 26, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindseywild lindseywild lindseywild approved these changes

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theerebuss @accessibility-bot @lindseywild
Morty Proxy This is a proxified and sanitized view of the page, visit original site.