Migrate all rules from using Counter in name
#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56
Similar to #57 but for the remaining rules.
For each existing rule, this PR:
is_counter_correct?call in a conditional. It also removes the autocorrect method which previously would insert correct counter comments.As a result of the renames, the diff is big, but the logic in the rule itself has not changed much, aside from removing the autocorrect feature and wrapping the counter call in each rule in a conditional.
I initially considered doing one PR for each rule, but decided to take of it in one go because making a PR for each rule is tedious for me, and the reviewer.
Successful test bump in dotcom ✅