Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dec5d16

Browse filesBrowse files
committed
simplify logic for now
1 parent 7fe1fd1 commit dec5d16
Copy full SHA for dec5d16

File tree

Expand file treeCollapse file tree

1 file changed

+1
-5
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-5
lines changed

‎lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb

Copy file name to clipboardExpand all lines: lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb
+1-5Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,10 @@ class NoVisuallyHiddenInteractiveElements < Linter
1414
MESSAGE = "Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element"
1515

1616
def run(processed_source)
17-
visually_hidden = false
18-
1917
tags(processed_source).each do |tag|
2018
next if tag.closing?
2119
classes = possible_attribute_values(tag, "class")
22-
visually_hidden = true if classes.include?("sr-only")
23-
next unless classes.include?("sr-only") || visually_hidden
24-
if INTERACTIVE_ELEMENTS.include?(tag.name)
20+
if classes.include?("sr-only") && INTERACTIVE_ELEMENTS.include?(tag.name)
2521
generate_offense(self.class, processed_source, tag)
2622
end
2723
end

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.