Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 79344aa

Browse filesBrowse files
authored
Merge pull request #106 from github/kh-update-guidance
Update aria-label-is-well-formatted.md
2 parents 46b8796 + 491a574 commit 79344aa
Copy full SHA for 79344aa

File tree

Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed

‎docs/rules/accessibility/aria-label-is-well-formatted.md

Copy file name to clipboardExpand all lines: docs/rules/accessibility/aria-label-is-well-formatted.md
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ Keep the following practices in mind:
1111
- Do not use line-break characters like `
`. An accessible name should be concise to start with.
1212
- Do not set the `aria-label` to a URL. Instead, use an appropriate human-friendly description.
1313

14+
### Be wary of `[aria-label]` on disallowed elements ⚠️
15+
16+
You may come across a scenario where `[aria-label]` is set on a generic `div` or `span`. This should also be flagged with the [NoAriaLabelMisuse](https://github.com/github/erblint-github/blob/main/docs/rules/accessibility/no-aria-label-misuse.md).
17+
18+
In this scenario, prioritize removing the `aria-label`!
19+
1420
## Resources
1521

1622
- [Staff only: Guidance on naming controls](https://github.com/github/accessibility-playbook/blob/main/content/link-and-button-guidance.mdx#guidance-on-naming-controls)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.