Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Conversation

@Shredder121
Copy link
Contributor

This has a few bonuses compared to manual pre.terminal elements.
It promotes readable authoring since code blocks are escaped automatically and the code examples are separated from the text.

@Shredder121
Copy link
Contributor Author

I assumed it's okay to change the content in changes/.
If it's a no go then I'll undo that.

At least, I hope that from now on the content can be authored in the new format. ✨

@kdaigle
Copy link
Member

kdaigle commented Sep 21, 2015

cc @gjtorikian do you have any thoughts on this change? 😄

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change this parenthetical to read:

If, for example, you need to emphasis text with <em>.

@gjtorikian
Copy link
Contributor

I made a tiny comment on the README text, but it's a great change. Crazy to think that we didn't do this before. I especially like the addition of terminals to text that previously didn't have them.

@Shredder121
Copy link
Contributor Author

Haha, thanks! I did indeed notice that there was a bad adoption of the terminal blocks.
Either the escaping made a lot look very ugly, or it was just not used.
I hope this helps at least from now on.

I'll address the comment on the README text.

This promotes readable authoring since code blocks are escaped automatically.
@Shredder121
Copy link
Contributor Author

Done.

kdaigle added a commit that referenced this pull request Sep 21, 2015
Document alternative .terminal block syntax
@kdaigle kdaigle merged commit edcc8eb into github:master Sep 21, 2015
@kdaigle
Copy link
Member

kdaigle commented Sep 21, 2015

@Shredder121 thanks! ✨

@Shredder121 Shredder121 deleted the terminal-blocks branch September 21, 2015 18:48
@Shredder121
Copy link
Contributor Author

Nice! Thank you as well, happy coding.

@Shredder121
Copy link
Contributor Author

Don't know if @kdaigle received the notification, but:
16f605e#commitcomment-13350791

There seems to be an ordering issue in the changes.atom feed.

Entries that have the same publish date seem to be randomly ordered.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.