This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Broken Last-Modified + no 'since' = a bit clunky #695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This would be better raised as an issue but you have them turned off. The patch is not to be taken entirely seriously.* The `*/events` endpoints: * return a `Last-Modified` header, but it's inaccurate and doesn't change when ETag does (you'll easily find events streams containing events paradoxically newer than the `Last-Modified` header) * do not support `since=<timestamp>` `Last-Modified` should be made accurate, removed or should carry a warning, to minimise confusion. Current behaviour means that a caller wanting to efficiently process only events since they last checked must store both the ETag (to avoid unconditional requests) and the timestamp (to manually discard events older than that) and still needs to request more events than they care about. It might be neater for callers and lighter on GitHub's bandwidth to make `Last-Modified` accurate and amenable to conditional requests, and/or to support `since` so that callers need only grab the events since their last check. That way, a single timestamp would be enough state.
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be better raised as an issue but you have them turned off. The patch is not to be taken entirely seriously. I'd use /contact but prefer issues to raised in the open.
The
*/eventsendpoints:Last-Modifiedheader, but it's inaccurate and doesn't change whenETagdoes (you'll easily find events streams containing events paradoxicallycreated_ata time newer than theLast-Modifiedheader)since=<timestamp>Last-Modifiedshould be made accurate, removed or should carry a warning, to minimise confusion.Current behaviour means that a caller wanting to efficiently process only events since they last checked must store both the
ETag(to avoid unconditional requests) and the timestamp (to manually discard events older than that) and still needs to request more events than they care about. It might be neater for callers and lighter on GitHub's bandwidth to makeLast-Modifiedaccurate and amenable to conditional requests, and/or to supportsinceso that callers need only grab the events since their last check. That way, a single timestamp would be enough state.