Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Removed Unneeded Predicate Clause #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Removed Unneeded Predicate Clause #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0321696
removed unneeded predicate
jsinglet Jul 21, 2022
85eb02c
changenote
jsinglet Jul 21, 2022
de6c69e
correct typos
jsinglet Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4 change_notes/2022-07-21-performance-fix-to-deadlock-query.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- `CON53-CPP` - `DeadlockByLockingInPredefinedOrder.ql`
- Optimized performance by removing unneeded conditionals.
- `CON35-C` - `DeadlockByLockingInPredefinedOrder.ql`
- Optimized performance by removing unneeded conditionals.
1 change: 0 additions & 1 deletion 1 ...s/preventdeadlockbylockinginpredefinedorder/PreventDeadlockByLockingInPredefinedOrder.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ predicate getAnOrderedLockPair(
lock2 = node.coveredByLock() and
not lock1 = lock2 and
lock1.getEnclosingFunction() = lock2.getEnclosingFunction() and
node.(Expr).getEnclosingFunction() = lock1.getEnclosingFunction() and
exists(Location l1Loc, Location l2Loc |
l1Loc = lock1.getLocation() and
l2Loc = lock2.getLocation()
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.