Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit ab94990

Browse filesBrowse files
jsingletjsinglet
authored
Merge pull request #38 from jsinglet/jsinglet/dev-mergeback-26
Mergeback for 2.6
2 parents fde0df0 + 6d167f3 commit ab94990
Copy full SHA for ab94990

File tree

2 files changed

+4
-1
lines changed
Filter options

2 files changed

+4
-1
lines changed

‎change_notes/2022-07-21-performance-fix-to-deadlock-query.md

Copy file name to clipboard
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
- `CON53-CPP` - `DeadlockByLockingInPredefinedOrder.ql`
2+
- Optimized performance by removing unneeded conditionals.
3+
- `CON35-C` - `DeadlockByLockingInPredefinedOrder.ql`
4+
- Optimized performance by removing unneeded conditionals.

‎cpp/common/src/codingstandards/cpp/rules/preventdeadlockbylockinginpredefinedorder/PreventDeadlockByLockingInPredefinedOrder.qll

Copy file name to clipboardExpand all lines: cpp/common/src/codingstandards/cpp/rules/preventdeadlockbylockinginpredefinedorder/PreventDeadlockByLockingInPredefinedOrder.qll
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ predicate getAnOrderedLockPair(
2525
lock2 = node.coveredByLock() and
2626
not lock1 = lock2 and
2727
lock1.getEnclosingFunction() = lock2.getEnclosingFunction() and
28-
node.(Expr).getEnclosingFunction() = lock1.getEnclosingFunction() and
2928
exists(Location l1Loc, Location l2Loc |
3029
l1Loc = lock1.getLocation() and
3130
l2Loc = lock2.getLocation()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.