Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 9e24b41

Browse filesBrowse files
lcarteylcartey
committed
Remove spurious recommendation tag
In some of the CERT help files they use "Recommendation" rather than "Rule" as a header in the Risk Assessment table, creating spurious query tags.
1 parent df44da0 commit 9e24b41
Copy full SHA for 9e24b41
Expand file treeCollapse file tree

10 files changed

+2
-12
lines changed

‎c/cert/src/rules/CON34-C/AppropriateThreadObjectStorageDurations.ql

Copy file name to clipboardExpand all lines: c/cert/src/rules/CON34-C/AppropriateThreadObjectStorageDurations.ql
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
* @tags external/cert/id/con34-c
1010
* correctness
1111
* concurrency
12-
* external/cert/recommendation/con34-c
1312
* external/cert/severity/medium
1413
* external/cert/likelihood/probable
1514
* external/cert/remediation-cost/high

‎c/cert/src/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.ql

Copy file name to clipboardExpand all lines: c/cert/src/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.ql
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
* external/cert/audit
1111
* correctness
1212
* concurrency
13-
* external/cert/recommendation/con34-c
1413
* external/cert/severity/medium
1514
* external/cert/likelihood/probable
1615
* external/cert/remediation-cost/high

‎c/cert/src/rules/EXP39-C/DoNotAccessVariableViaPointerOfIncompatibleType.ql

Copy file name to clipboardExpand all lines: c/cert/src/rules/EXP39-C/DoNotAccessVariableViaPointerOfIncompatibleType.ql
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
* @problem.severity error
99
* @tags external/cert/id/exp39-c
1010
* correctness
11-
* external/cert/recommendation/exp39-c
1211
* external/cert/severity/medium
1312
* external/cert/likelihood/unlikely
1413
* external/cert/remediation-cost/high

‎c/cert/src/rules/EXP45-C/AssignmentsInSelectionStatements.ql

Copy file name to clipboardExpand all lines: c/cert/src/rules/EXP45-C/AssignmentsInSelectionStatements.ql
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
* @problem.severity error
99
* @tags external/cert/id/exp45-c
1010
* correctness
11-
* external/cert/recommendation/exp45-c
1211
* external/cert/severity/low
1312
* external/cert/likelihood/likely
1413
* external/cert/remediation-cost/medium

‎c/cert/src/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.ql

Copy file name to clipboardExpand all lines: c/cert/src/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.ql
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
* @tags external/cert/id/mem36-c
1010
* correctness
1111
* security
12-
* external/cert/recommendation/mem36-c
1312
* external/cert/severity/low
1413
* external/cert/likelihood/probable
1514
* external/cert/remediation-cost/high

‎rule_packages/c/Concurrency4.json

Copy file name to clipboardExpand all lines: rule_packages/c/Concurrency4.json
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
"tags": [
4444
"correctness",
4545
"concurrency",
46-
"external/cert/recommendation/con34-c",
4746
"external/cert/severity/medium",
4847
"external/cert/likelihood/probable",
4948
"external/cert/remediation-cost/high",
@@ -65,7 +64,6 @@
6564
"external/cert/audit",
6665
"correctness",
6766
"concurrency",
68-
"external/cert/recommendation/con34-c",
6967
"external/cert/severity/medium",
7068
"external/cert/likelihood/probable",
7169
"external/cert/remediation-cost/high",

‎rule_packages/c/Memory2.json

Copy file name to clipboardExpand all lines: rule_packages/c/Memory2.json
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@
177177
"tags": [
178178
"correctness",
179179
"security",
180-
"external/cert/recommendation/mem36-c",
181180
"external/cert/severity/low",
182181
"external/cert/likelihood/probable",
183182
"external/cert/remediation-cost/high",

‎rule_packages/c/Pointers3.json

Copy file name to clipboardExpand all lines: rule_packages/c/Pointers3.json
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
"short_name": "DoNotAccessVariableViaPointerOfIncompatibleType",
6666
"tags": [
6767
"correctness",
68-
"external/cert/recommendation/exp39-c",
6968
"external/cert/severity/medium",
7069
"external/cert/likelihood/unlikely",
7170
"external/cert/remediation-cost/high",

‎rule_packages/c/SideEffects1.json

Copy file name to clipboardExpand all lines: rule_packages/c/SideEffects1.json
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@
7878
"short_name": "AssignmentsInSelectionStatements",
7979
"tags": [
8080
"correctness",
81-
"external/cert/recommendation/exp45-c",
8281
"external/cert/severity/low",
8382
"external/cert/likelihood/likely",
8483
"external/cert/remediation-cost/medium",

‎scripts/add_risk_assessment_tags.py

Copy file name to clipboardExpand all lines: scripts/add_risk_assessment_tags.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ def process_rule_package(rule_package_file):
123123
# Add each risk assessment property as a tag
124124
for key, value in risk_data.items():
125125
key_sanitized = key.lower().replace(" ", "-")
126-
if key_sanitized == "rule":
127-
# skip rule, as that is already in the rule ID
126+
if key_sanitized == "rule" or key_sanitized == "recommendation":
127+
# skip rule/recommendation as they just repeat the rule ID
128128
continue
129129
tag = f"external/cert/{key_sanitized}/{value.lower()}"
130130
if tag not in query["tags"]:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.