Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Install Python in update-bundle workflow#3277

Merged
mbg merged 3 commits intomaingithub/codeql-action:mainfrom
mbg/ci/update-bundle-pythongithub/codeql-action:mbg/ci/update-bundle-pythonCopy head branch name to clipboard
Nov 5, 2025
Merged

Install Python in update-bundle workflow#3277
mbg merged 3 commits intomaingithub/codeql-action:mainfrom
mbg/ci/update-bundle-pythongithub/codeql-action:mbg/ci/update-bundle-pythonCopy head branch name to clipboard

Conversation

@mbg
Copy link
Member

@mbg mbg commented Nov 5, 2025

This was missed in #3257 and led to the failure in https://github.com/github/codeql-action/actions/runs/19100037542/job/54569501824

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

CI only.

How did/will you validate this change?

  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

N/A

How will you know if something goes wrong after this change is released?

CI failure.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from henrymercer November 5, 2025 11:24
@mbg mbg self-assigned this Nov 5, 2025
@mbg mbg requested a review from a team as a code owner November 5, 2025 11:24
Copilot AI review requested due to automatic review settings November 5, 2025 11:24
@github-actions github-actions bot added the size/S Should be easy to review label Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors inline Python code in a GitHub Actions workflow into a separate script file. The changelog update logic that was previously embedded in the workflow YAML has been extracted to a standalone Python file.

  • Extracts inline Python code from the workflow into a dedicated script file
  • Adds Python setup step to ensure Python 3.12 is available for script execution
  • Simplifies the workflow step by replacing inline code with a script invocation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/update-bundle.yml Adds Python setup step and replaces inline Python code with script invocation
.github/workflows/script/bundle_changelog.py New script containing the extracted changelog update logic

.github/workflows/script/bundle_changelog.py Outdated Show resolved Hide resolved
henrymercer
henrymercer previously approved these changes Nov 5, 2025
.github/workflows/script/bundle_changelog.py Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mbg mbg enabled auto-merge November 5, 2025 11:35
@mbg mbg merged commit 423d14e into main Nov 5, 2025
241 checks passed
@mbg mbg deleted the mbg/ci/update-bundle-python branch November 5, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.