Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Re-enable Swift autobuild checks #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2024
Merged

Re-enable Swift autobuild checks #1621

merged 4 commits into from
Jun 17, 2024

Conversation

henrymercer
Copy link
Contributor

This PR re-enables the Swift autobuild checks. We should merge it once the macOS tracer issue is fixed.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Base automatically changed from henrymercer/disable-flaky-check to main March 28, 2023 20:01
@aeisenberg
Copy link
Contributor

The tracer fix is in. Let's see if this works now.

@aeisenberg aeisenberg force-pushed the henrymercer/reenable-swift-autobuild-checks branch 2 times, most recently from a244c9c to 5f275b3 Compare October 13, 2023 20:46
@aeisenberg aeisenberg force-pushed the henrymercer/reenable-swift-autobuild-checks branch from 5f275b3 to 7a14c3b Compare October 13, 2023 22:00
@aeisenberg
Copy link
Contributor

The lsregister bug has not been fixed yet, so we will still get occasional timeouts. We should keep this in draft until that issue is fixed, too.

@henrymercer henrymercer marked this pull request as ready for review June 17, 2024 10:30
@henrymercer henrymercer requested a review from a team as a code owner June 17, 2024 10:30
angelapwen
angelapwen approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :shipit:

@henrymercer henrymercer merged commit 1428e58 into main Jun 17, 2024
@henrymercer henrymercer deleted the henrymercer/reenable-swift-autobuild-checks branch June 17, 2024 11:30
This was referenced Jun 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@henrymercer @aeisenberg @angelapwen @Copilot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.