Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 94f08f3

Browse filesBrowse files
cklincklin
authored
Merge pull request #2698 from github/cklin/diff-informed-status-report
Add analysis_is_diff_informed to status report
2 parents 7ae5fc3 + 5889cfd commit 94f08f3
Copy full SHA for 94f08f3

File tree

Expand file treeCollapse file tree

6 files changed

+12
-2
lines changed
Filter options
Expand file treeCollapse file tree

6 files changed

+12
-2
lines changed

‎lib/analyze.js

Copy file name to clipboardExpand all lines: lib/analyze.js
+1Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/analyze.js.map

Copy file name to clipboardExpand all lines: lib/analyze.js.map
+1-1Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/analyze.test.js

Copy file name to clipboardExpand all lines: lib/analyze.test.js
+1Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/analyze.test.js.map

Copy file name to clipboardExpand all lines: lib/analyze.test.js.map
+1-1Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/analyze.test.ts

Copy file name to clipboardExpand all lines: src/analyze.test.ts
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ test("status report fields", async (t) => {
108108
createFeatures([Feature.QaTelemetryEnabled]),
109109
);
110110
t.deepEqual(Object.keys(statusReport).sort(), [
111+
"analysis_is_diff_informed",
111112
`analyze_builtin_queries_${language}_duration_ms`,
112113
"event_reports",
113114
`interpret_results_${language}_duration_ms`,

‎src/analyze.ts

Copy file name to clipboardExpand all lines: src/analyze.ts
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,12 @@ export interface QueriesStatusReport {
108108
/** Time taken in ms to interpret results for swift (or undefined if this language was not analyzed). */
109109
interpret_results_swift_duration_ms?: number;
110110

111+
/**
112+
* Whether the analysis is diff-informed (in the sense that the action generates a diff-range data
113+
* extension for the analysis, regardless of whether the data extension is actually used by queries).
114+
*/
115+
analysis_is_diff_informed?: boolean;
116+
111117
/** Name of language that errored during analysis (or undefined if no language failed). */
112118
analyze_failure_language?: string;
113119
/** Reports on discrete events associated with this status report. */
@@ -545,6 +551,7 @@ export async function runQueries(
545551
): Promise<QueriesStatusReport> {
546552
const statusReport: QueriesStatusReport = {};
547553

554+
statusReport.analysis_is_diff_informed = diffRangePackDir !== undefined;
548555
const dataExtensionFlags = diffRangePackDir
549556
? [
550557
`--additional-packs=${diffRangePackDir}`,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.