JS: support that the base is not a method-call in getAChainedMethodCall #8380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaeluka
previously approved these changes
Mar 10, 2022
There was a problem hiding this comment.
So, I'm understanding this correctly — the problem in your example is that in the third line below, inst is not a CallNode and therefore the bar call is not found? That's quite an easy mistake to make. As you're on a roll, this might be worth doing a ql-for-ql query for?
const Foo = require("foo");
const inst = new Foo();
const result = inst.bar();
Also, the check asks for a change note, but I think you can disable that.
Co-authored-by: Stephan Brandauer <kaeluka@github.com>
esbena
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets a TP for CVE-2021-46704
Evaluation was uneventful.
Consider the below.
This will not flag the below:
Because
DataFlow::moduleImport("foo").getAnInstantiation().getAMethodCall*()is restricted to the typeDataFlow::CallNode, even if we take 0 steps through the transitive closure.