-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Swift: Clarify the tag in the Swift updating doc #19558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,9 +3,9 @@ These files can only be updated having access for the internal repository at the | |
| In order to perform a Swift update: | ||
|
|
||
| 1. Dispatch the [internal `swift-prebuild` workflow](https://github.com/github/semmle-code/actions/workflows/__swift-prebuild.yml) with the appropriate swift | ||
| tag. | ||
| tag, e.g., `swift-6.1.1-RELEASE`. | ||
| 2. Dispatch [internal `swift-prepare-resource-dir` workflow](https://github.com/github/semmle-code/actions/workflows/__swift-prepare-resource-dir.yml) with the | ||
| appropriate swift tag. | ||
| appropriate swift tag, e.g., `swift-6.1.1-RELEASE`. | ||
|
Comment on lines
7
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Similarly, integrate this example into the numbered step to avoid an extra nested bullet. For example: 2. Dispatch the internal `swift-prepare-resource-dir` workflow with the appropriate Swift tag (e.g., `swift-6.1.1-RELEASE`).Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| 3. Once the jobs finish, staged artifacts are available | ||
| at https://github.com/dsp-testing/codeql-swift-artifacts/releases. Copy and paste the sha256 within the `_override` | ||
| definition in [`load.bzl`](../load.bzl). | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider merging this nested bullet into the main list item for readability. For example:
Copilot uses AI. Check for mistakes.