Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

JS: new Quality query - Unhandled errors in .pipe() chain #19544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: main
Choose a base branch
Loading
from
Draft

JS: new Quality query - Unhandled errors in .pipe() chain #19544

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c27157f
Add `UnhandledStreamPipee` Quality query and tests to detect missing …
Napalys May 20, 2025
f39bf62
test: Add edge cases for stream pipe error handling
Napalys May 20, 2025
ef1bde5
Fixed issue where streams would not be tracked via chainable methods
Napalys May 20, 2025
30f2815
Fixed issue where a custom `pipe` method which returns non stream wou…
Napalys May 20, 2025
03d1f9a
Restrict pipe detection to calls with 1-2 arguments
Napalys May 20, 2025
5710f0c
Add test cases for non-stream field accesses and methods before and a…
Napalys May 21, 2025
4332de4
Eliminate false positives by detecting non-stream objects returned fr…
Napalys May 21, 2025
d7f86db
Enhance PipeCall to exclude non-function and non-object arguments in …
Napalys May 22, 2025
09220fc
Fixed issue where `pipe` calls from `rxjs` package would been identif…
Napalys May 22, 2025
b104871
Added `UnhandledStreamPipe` to `javascript-security-and-quality.qls` …
Napalys May 22, 2025
5b1af0c
Added detection of custom `gulp-plumber` sanitizer, thus one would no…
Napalys May 22, 2025
ac24fdd
Add predicate to detect non-stream-like usage in sources of pipe calls
Napalys May 22, 2025
e6ae8bb
Added test cases where second parameter passed to `pipe` is a functio…
Napalys May 22, 2025
b10a948
Fixed false positives from `strapi` and `rxjs/testing` as well as whe…
Napalys May 22, 2025
15ff7cb
Added more test cases which common `js` libraries uses `.pipe()`
Napalys May 23, 2025
c6db32e
Add exceptions for `arktype`, `execa`, and `highland` to prevent them…
Napalys May 23, 2025
248f83c
Added `qhelp` for `UnhandledStreamPipe` query
Napalys May 23, 2025
000e69f
Replaced fuzzy `NonNodeStream` MaD to a ql predicate to deal easier w…
Napalys May 23, 2025
e964b17
Added `maintainability` and `error-handling` tags
Napalys May 26, 2025
5214cc0
Excluded `ngrx`, `datorama`, `angular`, `react` and `langchain` from …
Napalys May 27, 2025
5bb29b6
Now flags only `.pipe` calls which have an error somewhere down the s…
Napalys May 28, 2025
f8f5d8f
Exclude `.pipe` detection which are in a test file.
Napalys May 28, 2025
2e2b9a9
Make predicates private and clarify stream reference naming.
Napalys May 28, 2025
d3b2a57
Fixed ql warning `Expression can be replaced with a cast`
Napalys May 28, 2025
f843cc0
Fix false positives in stream pipe analysis by improving error handle…
Napalys May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added UnhandledStreamPipe to javascript-security-and-quality.qls … 
…and `javascript-code-quality.qls`
  • Loading branch information
@Napalys
Napalys committed May 22, 2025
commit b1048719aa48e9261ed5f077c2eb5598746ec14a
1 change: 1 addition & 0 deletions 1 javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
ql/javascript/ql/src/Expressions/MissingAwait.ql
ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
ql/javascript/ql/src/Quality/UnhandledStreamPipe.ql
ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql
1 change: 1 addition & 0 deletions 1 javascript/ql/integration-tests/query-suite/javascript-security-and-quality.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ ql/javascript/ql/src/NodeJS/InvalidExport.ql
ql/javascript/ql/src/NodeJS/MissingExports.ql
ql/javascript/ql/src/Performance/PolynomialReDoS.ql
ql/javascript/ql/src/Performance/ReDoS.ql
ql/javascript/ql/src/Quality/UnhandledStreamPipe.ql
ql/javascript/ql/src/React/DirectStateMutation.ql
ql/javascript/ql/src/React/InconsistentStateUpdate.ql
ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.