Go: Make type param test independent of standard library version #19532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the type parameter test so it only counts entities with source locations, preventing standard library additions from affecting results.
- Adds an
exists(ty.getLocation())check to the query predicate to filter out stdlib types without location metadata. - Cleans up the expected output by removing entries for standard library functions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/ql/test/library-tests/semmle/go/Function/TypeParamType.ql | Added location-existence filter and comment explaining it |
| go/ql/test/library-tests/semmle/go/Function/TypeParamType.expected | Removed unsupported standard library entries |
Comment on lines
11
to
12
| // Note that we cannot use the location of `ty` itself as we currently fail | ||
| // to extract an object for type parameters for methods on generic structs. |
There was a problem hiding this comment.
[nitpick] The comment suggests ty.getLocation() isn’t usable, yet the code now depends on it. Please update the comment to accurately describe why we require exists(ty.getLocation()).
Suggested change
| // Note that we cannot use the location of `ty` itself as we currently fail | |
| // to extract an object for type parameters for methods on generic structs. | |
| // We use `exists(ty.getLocation())` to ensure that `ty` has a valid location. | |
| // This is necessary because type parameters for methods on generic structs | |
| // may not always have an associated location in certain cases. |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
There was a problem hiding this comment.
This made me realise I wrote ty instead of tpt. I've force-pushed a fix to the comment.
This will make the test results not depend on the version of the standard library being used, which means we don't have to update it with each new release.
80999d9 to
f6f6a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the test results not depend on the version of the standard library being used, which means we don't have to update it with each new release.