Set CWE-134 from 9.3 to 7.3 CVSS score for memory safe languages #19530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sync up to score given to javascript/ruby
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the @security-severity rating for uncontrolled format string queries in memory-safe languages with existing JavaScript/Ruby rules by lowering it from 9.3 to 7.3.
- Reduced severity score in Swift, Java, and C# queries to 7.3
- Ensures consistency across supported memory-safe languages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| swift/ql/src/queries/Security/CWE-134/UncontrolledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
| java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
| csharp/ql/src/Security Features/CWE-134/UncontrolledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
|
Worth a changenote here or
no-change-note-required
|
|
It should have a change note. There is a guide here. It should be a query change note, with the category "queryMetadata". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adjusts the
@security-severitylevel for several queries related to uncontrolled format strings across memory safe languages to better reflect their impact. The risk is limited to application crashes or information disclosure, not system compromise. The severity has been reduced from9.3to7.3to match up to the similar Javascript / Ruby queries.codeql/javascript/ql/src/Security/CWE-134/TaintedFormatString.ql
Line 6 in e6235a5
codeql/javascript/ql/src/experimental/heuristics/ql/src/Security/CWE-134/TaintedFormatString.ql
Line 6 in e6235a5
codeql/ruby/ql/src/queries/security/cwe-134/TaintedFormatString.ql
Line 6 in e6235a5