Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

C/CPP: Update FlowSources to add wmain #19510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
Loading
from
Open

C/CPP: Update FlowSources to add wmain #19510

wants to merge 3 commits into from

Conversation

GeekMasher
Copy link
Member

This is to add support for applications with the wide-character version of the main function.

https://learn.microsoft.com/en-us/cpp/c-language/using-wmain?view=msvc-170

@Copilot Copilot AI review requested due to automatic review settings May 16, 2025 17:22
@GeekMasher GeekMasher requested a review from a team as a code owner May 16, 2025 17:22
Copilot
Copilot AI reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for wide-character entry points by treating wmain the same as main for argv flow sources.

  • Update doc comment to mention wmain
  • Extend ArgvSource to include wmain in its hasGlobalName check

@github-actions github-actions bot added the C++ label May 16, 2025
@GeekMasher @jketema
Update cpp/ql/lib/semmle/code/cpp/security/FlowSources.qll
bbce0d0 
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com>
@GeekMasher
Copy link
Member Author

@jketema Thanks for fixing that silly mistake, must have deleted it while updating it

jketema
jketema reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do like to run an DCA experiment on this before merging. I'll start one now.

@GeekMasher
Copy link
Member Author

I won't be able to merge this PR once ready, can you do that for me @jketema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeekMasher @jketema
Morty Proxy This is a proxified and sanitized view of the page, visit original site.