Rust: extract source files of dependencies #19506
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03e78be to
69eed04
Compare
69eed04 to
e4ee4a9
Compare
redsun82
reviewed
May 19, 2025
Comment on lines
+625
to
+630
| if let Some(body) = syntax.parent().and_then(Fn::cast).and_then(|x| x.body()) { | ||
| if body.syntax() == syntax { | ||
| tracing::debug!("Skipping Fn body"); | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
this should be equivalent and less nested, right?
Suggested change
| if let Some(body) = syntax.parent().and_then(Fn::cast).and_then(|x| x.body()) { | |
| if body.syntax() == syntax { | |
| tracing::debug!("Skipping Fn body"); | |
| return true; | |
| } | |
| } | |
| if syntax.parent().and_then(Fn::cast).and_then(|x| x.body().syntax()) == Some(syntax) { | |
| tracing::debug!("Skipping Fn body"); | |
| return true; | |
| } |
redsun82
reviewed
May 19, 2025
| @@ -612,6 +620,31 @@ impl<'a> Translator<'a> { | ||
| } | ||
|
|
||
| pub(crate) fn should_be_excluded(&self, item: &impl ast::HasAttrs) -> bool { |
There was a problem hiding this comment.
I'm wondering, shouldn't we also skip private things? or is that too hard because of the re-exporting thing?
There was a problem hiding this comment.
I think we should, but I first want to make the tests work again before optimising things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.