-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Release preparation for version 2.21.3 #19488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
||
### Minor Analysis Improvements | ||
|
||
* Changed the precision of the `cs/equality-on-floats` query from medium to high. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will result in it becoming part of the code-scanning
suite automatically, is that right @smowton ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not get added to code-scanning
suite due to the change in precision, as it is not tagged as a security query.
The query was added to the code-quality
suite here.
|
||
### New Features | ||
|
||
* Added AST nodes `UnsafeCastExpr`, `TypeValueExpr`, `IntegerType`, and `BuiltinFixedArrayType` that correspond to new nodes added by Swift 6.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What impact could this have on the results of analysing swift files @smowton ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None. TypeValueExpr
, IntegerType
, and BuiltinFixedArrayType
are experimental Swift features that cannot really be used as far as I can tell, and UnsafeCastExpr
is just another kind an implicit conversion, and implicit conversions we already supported.
No description provided.