Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Go: Remove redundant code in IR::ExtractTupleElementInstruction.getResultType() and expand tests #19484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

Go: Remove redundant code in IR::ExtractTupleElementInstruction.getResultType() and expand tests #19484

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b064911
Expand test for Extract Tuple Instruction
owen-mc May 13, 2025
7da1ade
Add tests for extracting tuples in `f(g(...))`
owen-mc May 13, 2025
933e01b
Remove redundant code
owen-mc May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove redundant code 
The case of a CallExpr is actually covered by the next disjunct.

Note that the CallExpr case had a subtle bug: `c.getTarget()` is not
defined when we are calling a variable. Better to use
`c.getCalleeType()`. But in this case we can just delete the code.
  • Loading branch information
@owen-mc
owen-mc committed May 13, 2025
commit 933e01b3d4de4d1adb7d263f219cf67ecfd0d3d5
4 changes: 0 additions & 4 deletions 4 go/ql/lib/semmle/go/controlflow/IR.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,10 +718,6 @@ module IR {
predicate extractsElement(Instruction base, int idx) { base = this.getBase() and idx = i }

override Type getResultType() {
exists(CallExpr c | this.getBase() = evalExprInstruction(c) |
result = c.getTarget().getResultType(i)
)
or
exists(Expr e | this.getBase() = evalExprInstruction(e) |
result = e.getType().(TupleType).getComponentType(pragma[only_bind_into](i))
)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.