Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Go: Support 1.23 (Transparent aliases) #17358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Go: Support 1.23 (Transparent aliases) #17358

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d790d1f
Go: Use 1.23 in build process
mbg Jul 24, 2024
ca796b0
Go: Use 1.23 in tests
mbg Jul 24, 2024
4dead2b
Go: Use 1.23 for extractor
mbg Jul 24, 2024
c8e7324
Go: Update frontend error messages for Go 1.23
mbg Jul 24, 2024
c5b8163
Go: Handle `Alias` types by extracting the underlying types
mbg Sep 2, 2024
97c3efc
Go: Factor out `isAlias` function
mbg Sep 3, 2024
1a9608a
Go: Don't extract objects for type aliases
mbg Sep 3, 2024
8380d71
Go: Add test for `AliasType` extraction
mbg Aug 16, 2024
195f372
Go: Accept new test results
mbg Sep 4, 2024
6ef5063
Go: Format `Aliases.ql`
mbg Sep 4, 2024
9aeaae6
Go: Bump `maxGoVersion` to `1.23`
mbg Sep 4, 2024
772bc9b
Go: Bump everything to 1.23.1
mbg Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Go: Don't extract objects for type aliases
  • Loading branch information
@mbg
mbg committed Sep 5, 2024
commit 1a9608a1f5a7d4b0fea233f0bffb0721b765dda9
2 changes: 1 addition & 1 deletion 2 go/extractor/extractor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,7 @@ func isAlias(tp types.Type) bool {
// If the given type is a type alias, this function resolves it to its underlying type.
func resolveTypeAlias(tp types.Type) types.Type {
if isAlias(tp) {
return tp.Underlying()
return types.Unalias(tp) // tp.Underlying()
}
return tp
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.