-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JS: Web Cache Deception Express #15180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aydinnyunus
wants to merge
6
commits into
github:main
Choose a base branch
from
aydinnyunus:express_web_cache_deception
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2e04655
add rule and example code for express
krakendio 8a3018e
add rule and example code for express
krakendio bacde7f
update example code
krakendio 3ec7ac5
update example code
krakendio c830a04
add missing files
krakendio f8ad494
fix formatting
krakendio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add missing files
- Loading branch information
commit c830a0475b77ae202a19b188de88adba739bfa9e
There are no files selected for viewing
20 changes: 20 additions & 0 deletions
20
javascript/ql/test/experimental/Security/CWE-525/WebCacheDeception.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** | ||
* @name Web Cache Deception in Express | ||
* @description A caching system has been detected on the application and is vulnerable to web cache deception. By manipulating the URL it is possible to force the application to cache pages that are only accessible by an authenticated user. Once cached, these pages can be accessed by an unauthenticated user. | ||
* @kind problem | ||
* @problem.severity error | ||
* @security-severity 9 | ||
* @precision medium | ||
* @id js/web-cache-deception-express | ||
* @tags javascript | ||
* cwe-525 | ||
* bug | ||
*/ | ||
|
||
import javascript | ||
import WebCacheDeceptionLib | ||
|
||
from WebCacheDeception::Sink httpHandleFuncCall | ||
where httpHandleFuncCall.toString().matches("%*%") | ||
select httpHandleFuncCall, httpHandleFuncCall + " is used as wildcard endpoint." | ||
|
16 changes: 16 additions & 0 deletions
16
javascript/ql/test/experimental/Security/CWE-525/WebCacheDeceptionLib.qll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import javascript | ||
import StringOps | ||
|
||
module WebCacheDeception { | ||
abstract class Sink extends DataFlow::Node { } | ||
|
||
private class Express extends Sink { | ||
Express() { | ||
exists(Import is | is.getImportedModuleNode().getASuccessor().toString() = "express") and | ||
exists(DataFlow::CallNode m | | ||
m.getAMethodCall().getArgument(0).getStringValue().matches("%*") and | ||
this = m.getAMethodCall().getArgument(0) | ||
) | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.