C++: Implement getAdditionalFlowIntoCallNodeTerm
#12429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCA looks good: The mono run managed to analyze the problematic project without OOM'ing, and the other run shows no result changes 🎉. |
jketema
reviewed
Mar 8, 2023
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
jketema
approved these changes
Mar 8, 2023
Hm, good point. I'll run it just to be safe |
|
DCA confirms that the refactorings in 5a6b94e didn't cause any regressions. The CI failures are unrelated to this, so I'll 🤠 merge this! |
c84d88f
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the predicate added to the shared dataflow library in #12236. The goal is to identify which
switchstatements read from/write a given parameter in many branches, which we've seen can cause a large number of access paths to be generated for certain projects.I've started two DCA runs: One "normal" DCA run that compares the base branch with this PR (to inspect any performance or result changes), and one that just runs on this branch (since the problematic project will probably still OOM on the base branch, thus not even getting to running on this PR's branch).