Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d49f05f

Browse filesBrowse files
owen-mcowen-mc
committed
Test changes
1 parent 521b971 commit d49f05f
Copy full SHA for d49f05f

File tree

7 files changed

+2
-47
lines changed
Filter options

7 files changed

+2
-47
lines changed

‎go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalFlowStep.expected

Copy file name to clipboardExpand all lines: go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalFlowStep.expected
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@
6868
| main.go:11:14:11:14 | z | main.go:11:9:11:15 | type conversion |
6969
| main.go:14:6:14:10 | function test2 | main.go:34:8:34:12 | test2 |
7070
| main.go:14:6:14:10 | function test2 | main.go:34:19:34:23 | test2 |
71-
| main.go:15:2:15:4 | definition of acc | main.go:16:9:19:2 | capture variable acc |
72-
| main.go:15:9:15:9 | 0 | main.go:15:2:15:4 | definition of acc |
7371
| main.go:16:9:19:2 | capture variable acc | main.go:17:3:17:5 | acc |
7472
| main.go:17:3:17:7 | definition of acc | main.go:16:9:19:2 | capture variable acc |
7573
| main.go:17:3:17:7 | definition of acc | main.go:18:10:18:12 | acc |

‎go/ql/test/library-tests/semmle/go/dataflow/GlobalValueNumbering/GlobalValueNumber.expected

Copy file name to clipboardExpand all lines: go/ql/test/library-tests/semmle/go/dataflow/GlobalValueNumbering/GlobalValueNumber.expected
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,9 @@
2727
| main.go:29:8:29:8 | 5 | main.go:29:8:29:8 | 5 |
2828
| main.go:30:9:30:9 | 6 | main.go:30:9:30:9 | 6 |
2929
| main.go:30:9:30:9 | definition of res | main.go:30:9:30:9 | 6 |
30-
| main.go:33:15:33:17 | definition of res | main.go:10:7:10:7 | 0 |
3130
| main.go:33:15:33:17 | zero value for res | main.go:10:7:10:7 | 0 |
32-
| main.go:34:2:34:4 | definition of res | main.go:34:8:34:8 | 7 |
3331
| main.go:34:8:34:8 | 7 | main.go:34:8:34:8 | 7 |
3432
| main.go:35:8:37:4 | function call | main.go:35:8:37:4 | function call |
35-
| main.go:36:3:36:5 | definition of res | main.go:36:9:36:9 | 8 |
3633
| main.go:36:9:36:9 | 8 | main.go:36:9:36:9 | 8 |
3734
| main.go:38:9:38:9 | 9 | main.go:38:9:38:9 | 9 |
3835
| main.go:38:9:38:9 | definition of res | main.go:38:9:38:9 | 9 |

‎go/ql/test/library-tests/semmle/go/dataflow/SSA/SsaDefinition.expected

Copy file name to clipboardExpand all lines: go/ql/test/library-tests/semmle/go/dataflow/SSA/SsaDefinition.expected
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
| main.go:95:22:95:28 | definition of wrapper |
3636
| main.go:96:2:96:2 | definition of x |
3737
| main.go:97:2:99:3 | capture variable x |
38-
| main.go:98:3:98:3 | definition of x |
3938
| main.go:103:20:103:26 | definition of wrapper |
4039
| main.go:104:2:104:2 | definition of x |
4140
| main.go:105:16:108:2 | capture variable x |
@@ -45,7 +44,6 @@
4544
| main.go:114:2:117:3 | capture variable x |
4645
| main.go:114:16:117:2 | capture variable x |
4746
| main.go:115:3:115:3 | definition of y |
48-
| main.go:116:3:116:3 | definition of x |
4947
| main.go:130:3:130:3 | definition of p |
5048
| main.go:132:3:132:3 | definition of p |
5149
| main.go:135:2:135:2 | p = phi(def@130:3, def@132:3) |

‎go/ql/test/library-tests/semmle/go/dataflow/SSA/SsaWithFields.expected

Copy file name to clipboardExpand all lines: go/ql/test/library-tests/semmle/go/dataflow/SSA/SsaWithFields.expected
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
| main.go:95:22:95:28 | (def@95:22).s | wrapper.s |
3737
| main.go:96:2:96:2 | (def@96:2) | x |
3838
| main.go:97:2:99:3 | (capture@97:2) | x |
39-
| main.go:98:3:98:3 | (def@98:3) | x |
4039
| main.go:103:20:103:26 | (def@103:20) | wrapper |
4140
| main.go:103:20:103:26 | (def@103:20).s | wrapper.s |
4241
| main.go:104:2:104:2 | (def@104:2) | x |
@@ -48,7 +47,6 @@
4847
| main.go:114:2:117:3 | (capture@114:2) | x |
4948
| main.go:114:16:117:2 | (capture@114:16) | x |
5049
| main.go:115:3:115:3 | (def@115:3) | y |
51-
| main.go:116:3:116:3 | (def@116:3) | x |
5250
| main.go:130:3:130:3 | (def@130:3) | p |
5351
| main.go:132:3:132:3 | (def@132:3) | p |
5452
| main.go:135:2:135:2 | (phi@135:2) | p |

‎go/ql/test/library-tests/semmle/go/frameworks/Twirp/RequestForgery.expected

Copy file name to clipboardExpand all lines: go/ql/test/library-tests/semmle/go/frameworks/Twirp/RequestForgery.expected
-24Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,23 @@
11
#select
2-
| server/main.go:30:38:30:48 | selection of Text | rpc/notes/service.twirp.go:538:25:538:32 | selection of Body | server/main.go:30:38:30:48 | selection of Text | The $@ of this request depends on a $@. | server/main.go:30:38:30:48 | selection of Text | URL | rpc/notes/service.twirp.go:538:25:538:32 | selection of Body | user-provided value |
32
| server/main.go:30:38:30:48 | selection of Text | server/main.go:19:56:19:61 | definition of params | server/main.go:30:38:30:48 | selection of Text | The $@ of this request depends on a $@. | server/main.go:30:38:30:48 | selection of Text | URL | server/main.go:19:56:19:61 | definition of params | user-provided value |
43
edges
54
| client/main.go:16:35:16:78 | &... | server/main.go:19:56:19:61 | definition of params | provenance | |
65
| rpc/notes/service.twirp.go:473:6:473:13 | definition of typedReq | rpc/notes/service.twirp.go:477:44:477:51 | typedReq | provenance | |
76
| rpc/notes/service.twirp.go:477:44:477:51 | typedReq | server/main.go:19:56:19:61 | definition of params | provenance | |
8-
| rpc/notes/service.twirp.go:493:2:496:2 | capture variable reqContent | rpc/notes/service.twirp.go:495:35:495:44 | reqContent | provenance | |
9-
| rpc/notes/service.twirp.go:495:35:495:44 | reqContent | server/main.go:19:56:19:61 | definition of params | provenance | |
10-
| rpc/notes/service.twirp.go:538:2:538:33 | ... := ...[0] | rpc/notes/service.twirp.go:544:27:544:29 | buf | provenance | |
11-
| rpc/notes/service.twirp.go:538:25:538:32 | selection of Body | rpc/notes/service.twirp.go:538:2:538:33 | ... := ...[0] | provenance | Src:MaD:1 MaD:3 |
12-
| rpc/notes/service.twirp.go:543:2:543:11 | definition of reqContent | rpc/notes/service.twirp.go:574:2:577:2 | capture variable reqContent | provenance | |
13-
| rpc/notes/service.twirp.go:543:2:543:11 | definition of reqContent | rpc/notes/service.twirp.go:576:35:576:44 | reqContent | provenance | |
14-
| rpc/notes/service.twirp.go:544:27:544:29 | buf | rpc/notes/service.twirp.go:543:2:543:11 | definition of reqContent | provenance | MaD:2 |
157
| rpc/notes/service.twirp.go:554:6:554:13 | definition of typedReq | rpc/notes/service.twirp.go:558:44:558:51 | typedReq | provenance | |
168
| rpc/notes/service.twirp.go:558:44:558:51 | typedReq | server/main.go:19:56:19:61 | definition of params | provenance | |
17-
| rpc/notes/service.twirp.go:574:2:577:2 | capture variable reqContent | rpc/notes/service.twirp.go:576:35:576:44 | reqContent | provenance | |
18-
| rpc/notes/service.twirp.go:576:35:576:44 | reqContent | server/main.go:19:56:19:61 | definition of params | provenance | |
199
| server/main.go:19:56:19:61 | definition of params | server/main.go:19:56:19:61 | definition of params [Return] | provenance | |
2010
| server/main.go:19:56:19:61 | definition of params | server/main.go:30:38:30:48 | selection of Text | provenance | |
2111
| server/main.go:19:56:19:61 | definition of params | server/main.go:30:38:30:48 | selection of Text | provenance | |
2212
| server/main.go:19:56:19:61 | definition of params [Return] | client/main.go:16:35:16:78 | &... | provenance | |
2313
| server/main.go:19:56:19:61 | definition of params [Return] | rpc/notes/service.twirp.go:473:6:473:13 | definition of typedReq | provenance | |
24-
| server/main.go:19:56:19:61 | definition of params [Return] | rpc/notes/service.twirp.go:493:2:496:2 | capture variable reqContent | provenance | |
2514
| server/main.go:19:56:19:61 | definition of params [Return] | rpc/notes/service.twirp.go:554:6:554:13 | definition of typedReq | provenance | |
26-
| server/main.go:19:56:19:61 | definition of params [Return] | rpc/notes/service.twirp.go:574:2:577:2 | capture variable reqContent | provenance | |
27-
models
28-
| 1 | Source: net/http; Request; true; Body; ; ; ; remote; manual |
29-
| 2 | Summary: google.golang.org/protobuf/proto; ; false; Unmarshal; ; ; Argument[0]; Argument[1]; taint; manual |
30-
| 3 | Summary: io; ; false; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
3115
nodes
3216
| client/main.go:16:35:16:78 | &... | semmle.label | &... |
3317
| rpc/notes/service.twirp.go:473:6:473:13 | definition of typedReq | semmle.label | definition of typedReq |
3418
| rpc/notes/service.twirp.go:477:44:477:51 | typedReq | semmle.label | typedReq |
35-
| rpc/notes/service.twirp.go:493:2:496:2 | capture variable reqContent | semmle.label | capture variable reqContent |
36-
| rpc/notes/service.twirp.go:495:35:495:44 | reqContent | semmle.label | reqContent |
37-
| rpc/notes/service.twirp.go:538:2:538:33 | ... := ...[0] | semmle.label | ... := ...[0] |
38-
| rpc/notes/service.twirp.go:538:25:538:32 | selection of Body | semmle.label | selection of Body |
39-
| rpc/notes/service.twirp.go:543:2:543:11 | definition of reqContent | semmle.label | definition of reqContent |
40-
| rpc/notes/service.twirp.go:544:27:544:29 | buf | semmle.label | buf |
4119
| rpc/notes/service.twirp.go:554:6:554:13 | definition of typedReq | semmle.label | definition of typedReq |
4220
| rpc/notes/service.twirp.go:558:44:558:51 | typedReq | semmle.label | typedReq |
43-
| rpc/notes/service.twirp.go:574:2:577:2 | capture variable reqContent | semmle.label | capture variable reqContent |
44-
| rpc/notes/service.twirp.go:576:35:576:44 | reqContent | semmle.label | reqContent |
4521
| server/main.go:19:56:19:61 | definition of params | semmle.label | definition of params |
4622
| server/main.go:19:56:19:61 | definition of params | semmle.label | definition of params |
4723
| server/main.go:19:56:19:61 | definition of params [Return] | semmle.label | definition of params [Return] |

‎go/ql/test/query-tests/InconsistentCode/UnhandledCloseWritableHandle/UnhandledCloseWritableHandle.expected

Copy file name to clipboardExpand all lines: go/ql/test/query-tests/InconsistentCode/UnhandledCloseWritableHandle/UnhandledCloseWritableHandle.expected
-14Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,16 @@
11
#select
22
| tests.go:9:8:9:8 | f | tests.go:31:5:31:78 | ... := ...[0] | tests.go:9:8:9:8 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:31:15:31:78 | call to OpenFile | call to OpenFile |
33
| tests.go:9:8:9:8 | f | tests.go:45:5:45:76 | ... := ...[0] | tests.go:9:8:9:8 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:45:15:45:76 | call to OpenFile | call to OpenFile |
4-
| tests.go:14:3:14:3 | f | tests.go:31:5:31:78 | ... := ...[0] | tests.go:14:3:14:3 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:31:15:31:78 | call to OpenFile | call to OpenFile |
5-
| tests.go:14:3:14:3 | f | tests.go:45:5:45:76 | ... := ...[0] | tests.go:14:3:14:3 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:45:15:45:76 | call to OpenFile | call to OpenFile |
64
| tests.go:56:3:56:3 | f | tests.go:54:5:54:78 | ... := ...[0] | tests.go:56:3:56:3 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:54:15:54:78 | call to OpenFile | call to OpenFile |
75
| tests.go:68:3:68:3 | f | tests.go:66:5:66:76 | ... := ...[0] | tests.go:68:3:68:3 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:66:15:66:76 | call to OpenFile | call to OpenFile |
86
| tests.go:110:9:110:9 | f | tests.go:108:5:108:78 | ... := ...[0] | tests.go:110:9:110:9 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:108:15:108:78 | call to OpenFile | call to OpenFile |
97
| tests.go:129:3:129:3 | f | tests.go:125:5:125:78 | ... := ...[0] | tests.go:129:3:129:3 | f | File handle may be writable as a result of data flow from a $@ and closing it may result in data loss upon failure, which is not handled explicitly. | tests.go:125:15:125:78 | call to OpenFile | call to OpenFile |
108
edges
119
| tests.go:8:24:8:24 | definition of f | tests.go:9:8:9:8 | f | provenance | |
12-
| tests.go:12:32:12:32 | definition of f | tests.go:13:13:15:2 | capture variable f | provenance | |
13-
| tests.go:12:32:12:32 | definition of f | tests.go:14:3:14:3 | f | provenance | |
14-
| tests.go:13:13:15:2 | capture variable f | tests.go:14:3:14:3 | f | provenance | |
1510
| tests.go:31:5:31:78 | ... := ...[0] | tests.go:32:21:32:21 | f | provenance | Src:MaD:1 |
16-
| tests.go:31:5:31:78 | ... := ...[0] | tests.go:33:29:33:29 | f | provenance | Src:MaD:1 |
1711
| tests.go:32:21:32:21 | f | tests.go:8:24:8:24 | definition of f | provenance | |
18-
| tests.go:33:29:33:29 | f | tests.go:12:32:12:32 | definition of f | provenance | |
1912
| tests.go:45:5:45:76 | ... := ...[0] | tests.go:46:21:46:21 | f | provenance | Src:MaD:1 |
20-
| tests.go:45:5:45:76 | ... := ...[0] | tests.go:47:29:47:29 | f | provenance | Src:MaD:1 |
2113
| tests.go:46:21:46:21 | f | tests.go:8:24:8:24 | definition of f | provenance | |
22-
| tests.go:47:29:47:29 | f | tests.go:12:32:12:32 | definition of f | provenance | |
2314
| tests.go:54:5:54:78 | ... := ...[0] | tests.go:56:3:56:3 | f | provenance | Src:MaD:1 |
2415
| tests.go:66:5:66:76 | ... := ...[0] | tests.go:68:3:68:3 | f | provenance | Src:MaD:1 |
2516
| tests.go:108:5:108:78 | ... := ...[0] | tests.go:110:9:110:9 | f | provenance | Src:MaD:1 |
@@ -29,15 +20,10 @@ models
2920
nodes
3021
| tests.go:8:24:8:24 | definition of f | semmle.label | definition of f |
3122
| tests.go:9:8:9:8 | f | semmle.label | f |
32-
| tests.go:12:32:12:32 | definition of f | semmle.label | definition of f |
33-
| tests.go:13:13:15:2 | capture variable f | semmle.label | capture variable f |
34-
| tests.go:14:3:14:3 | f | semmle.label | f |
3523
| tests.go:31:5:31:78 | ... := ...[0] | semmle.label | ... := ...[0] |
3624
| tests.go:32:21:32:21 | f | semmle.label | f |
37-
| tests.go:33:29:33:29 | f | semmle.label | f |
3825
| tests.go:45:5:45:76 | ... := ...[0] | semmle.label | ... := ...[0] |
3926
| tests.go:46:21:46:21 | f | semmle.label | f |
40-
| tests.go:47:29:47:29 | f | semmle.label | f |
4127
| tests.go:54:5:54:78 | ... := ...[0] | semmle.label | ... := ...[0] |
4228
| tests.go:56:3:56:3 | f | semmle.label | f |
4329
| tests.go:66:5:66:76 | ... := ...[0] | semmle.label | ... := ...[0] |

‎go/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/DeadStoreOfLocal.expected

Copy file name to clipboardExpand all lines: go/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/DeadStoreOfLocal.expected
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
| testdata.go:172:3:172:3 | assignment to x | This definition of x is never used. |
1717
| testdata.go:180:3:180:5 | increment statement | This definition of x is never used. |
1818
| testdata.go:201:2:201:2 | assignment to x | This definition of x is never used. |
19+
| testdata.go:227:3:227:5 | increment statement | This definition of x is never used. |
20+
| testdata.go:235:3:235:3 | assignment to x | This definition of x is never used. |
1921
| testdata.go:262:2:262:2 | assignment to x | This definition of x is never used. |
2022
| testdata.go:268:2:268:2 | assignment to x | This definition of x is never used. |
2123
| testdata.go:309:2:309:2 | assignment to a | This definition of a is never used. |

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.