Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c71898c

Browse filesBrowse files
committed
Java: Consistent naming of TContent cases
1 parent 3ae793d commit c71898c
Copy full SHA for c71898c

File tree

Expand file treeCollapse file tree

3 files changed

+28
-25
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+28
-25
lines changed

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowNodes.qll

Copy file name to clipboardExpand all lines: java/ql/lib/semmle/code/java/dataflow/internal/DataFlowNodes.qll
+8-4Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,10 @@ private module Cached {
7070
TMapValueContent() or
7171
TCapturedVariableContent(CapturedVariable v) or
7272
TSyntheticFieldContent(SyntheticField s) or
73-
TLambdaReturn(Method m) or
74-
TLambdaArgument(Method m, ArgumentPosition pos)
73+
TLambdaReturnContent(Method m) or
74+
TLambdaArgumentContent(Method m, ArgumentPosition pos) {
75+
exists(m.getParameter(pos)) or pos = -1
76+
}
7577

7678
cached
7779
newtype TContentApprox =
@@ -82,8 +84,10 @@ private module Cached {
8284
TMapValueContentApprox() or
8385
TCapturedVariableContentApprox(CapturedVariable v) or
8486
TSyntheticFieldApproxContent() or
85-
TLambdaReturnApprox(Method m) or
86-
TLambdaArgumentApprox(Method m, ArgumentPosition pos)
87+
TLambdaReturnContentApprox(Method m) or
88+
TLambdaArgumentApprox(Method m, ArgumentPosition pos) {
89+
exists(m.getParameter(pos)) or pos = -1
90+
}
8791
}
8892

8993
import Cached

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll

Copy file name to clipboardExpand all lines: java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
+12-9Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,9 @@ class LambdaSynthCall extends DataFlowCall, TLambdaSynthCall {
533533

534534
LambdaSynthCall() { this = TLambdaSynthCall(node) }
535535

536-
override DataFlowCallable getEnclosingCallable() { result.asCallable() = node.getEnclosingCallable() }
536+
override DataFlowCallable getEnclosingCallable() {
537+
result.asCallable() = node.getEnclosingCallable()
538+
}
537539

538540
override string toString() { result = "[synthetic] call to " + node }
539541

@@ -611,7 +613,9 @@ predicate lambdaCreationHelper(Node creation, LambdaCallKind kind, DataFlowCalla
611613
}
612614

613615
/** Holds if `creation` is an expression that creates a lambda of kind `kind` for `c`. */
614-
predicate lambdaCreation(Node creation, LambdaCallKind kind, DataFlowCallable c, DataFlowCall synthCall) {
616+
predicate lambdaCreation(
617+
Node creation, LambdaCallKind kind, DataFlowCallable c, DataFlowCall synthCall
618+
) {
615619
synthCall = TLambdaSynthCall(creation) and
616620
lambdaCreationHelper(creation, kind, c)
617621
}
@@ -775,12 +779,11 @@ ContentApprox getContentApprox(Content c) {
775779
or
776780
c instanceof SyntheticFieldContent and result = TSyntheticFieldApproxContent()
777781
or
778-
exists(Method m |
779-
c = TLambdaReturn(m) and result = TLambdaReturnApprox(m))
782+
exists(Method m | c = TLambdaReturnContent(m) and result = TLambdaReturnContentApprox(m))
780783
or
781784
exists(Method m, ArgumentPosition pos |
782-
c = TLambdaArgument(m, pos) and result = TLambdaArgumentApprox(m, pos))
783-
785+
c = TLambdaArgumentContent(m, pos) and result = TLambdaArgumentApprox(m, pos)
786+
)
784787
}
785788

786789
/**
@@ -794,13 +797,13 @@ predicate containerContent(ContentSet c) {
794797
}
795798

796799
Content getLambdaReturnContent(LambdaCallKind kind, ReturnKind k) {
797-
result = TLambdaReturn(kind) and exists(k)
800+
result = TLambdaReturnContent(kind) and exists(k)
798801
}
799802

800803
Content getLambdaArgumentContent(LambdaCallKind kind, ArgumentPosition pos) {
801-
result = TLambdaArgument(kind, pos)
804+
result = TLambdaArgumentContent(kind, pos)
802805
}
803806

804807
predicate isLambdaInstanceParameter(ParameterNode p) {
805808
exists(DataFlowCallable c | lambdaCreationHelper(_, _, c) and p.isParameterOf(c, -1))
806-
}
809+
}

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowUtil.qll

Copy file name to clipboardExpand all lines: java/ql/lib/semmle/code/java/dataflow/internal/DataFlowUtil.qll
+8-12Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -360,31 +360,27 @@ class SyntheticFieldContent extends Content, TSyntheticFieldContent {
360360
override string toString() { result = s.toString() }
361361
}
362362

363-
class LambdaReturnContent extends Content, TLambdaReturn {
363+
class LambdaReturnContent extends Content, TLambdaReturnContent {
364364
Method m;
365365

366-
LambdaReturnContent() { this = TLambdaReturn(m) }
366+
LambdaReturnContent() { this = TLambdaReturnContent(m) }
367367

368-
override DataFlowType getType() {
369-
result = getErasedRepr(m.getReturnType())
370-
}
368+
override DataFlowType getType() { result = getErasedRepr(m.getReturnType()) }
371369

372370
override string toString() { result = "<lambda-return>" }
373371
}
374372

375-
class LambdaArgumentContent extends Content, TLambdaArgument {
373+
class LambdaArgumentContent extends Content, TLambdaArgumentContent {
376374
Method m;
377375
ArgumentPosition pos;
378376

379-
LambdaArgumentContent() {
380-
this = TLambdaArgument(m, pos)
381-
}
377+
LambdaArgumentContent() { this = TLambdaArgumentContent(m, pos) }
378+
379+
override DataFlowType getType() { result = getErasedRepr(m.getParameter(pos).getType()) }
382380

383-
override DataFlowType getType() {
384-
result = getErasedRepr(m.getParameter(pos).getType())
385-
}
386381
override string toString() { result = "<lambda-argument>" + pos.toString() }
387382
}
383+
388384
/**
389385
* An entity that represents a set of `Content`s.
390386
*

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.