Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 43325f4

Browse filesBrowse files
committed
Actions: resolve TODOs from diff-informed patch
1 parent 12bf31e commit 43325f4
Copy full SHA for 43325f4

File tree

1 file changed

+2
-6
lines changed
Filter options

1 file changed

+2
-6
lines changed

‎actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll

Copy file name to clipboardExpand all lines: actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ private module ActionsMutableRefCheckoutConfig implements DataFlow::ConfigSig {
7272
}
7373

7474
predicate observeDiffInformedIncrementalMode() {
75-
// TODO(diff-informed): Manually verify if config can be diff-informed.
76-
// actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll:238: Flow call outside 'select' clause
77-
none()
75+
none() // The query does not use the PathGraph from this data flow config
7876
}
7977
}
8078

@@ -129,9 +127,7 @@ private module ActionsSHACheckoutConfig implements DataFlow::ConfigSig {
129127
}
130128

131129
predicate observeDiffInformedIncrementalMode() {
132-
// TODO(diff-informed): Manually verify if config can be diff-informed.
133-
// actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll:273: Flow call outside 'select' clause
134-
none()
130+
none() // The query does not use the PathGraph from this data flow config
135131
}
136132
}
137133

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.