Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Use modern clone dialog when re-cloning a repository #2202

Merged
jcansdale merged 4 commits into from
Jan 29, 2019
Merged

Use modern clone dialog when re-cloning a repository #2202

jcansdale merged 4 commits into from
Jan 29, 2019

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jan 28, 2019 •
edited
Loading

Depends on #2198

Now that the clone dialog can clone any arbitrary GitHub URL (not just ones owned by the user), we don't need a separate dialog when re-cloning a URL using the Start Page.

What this PR does

  • Use the same clone dialog when cloning a new repository or re-cloning one that has been cloned before
  • Remove the obsolete ShowReCloneDialog API and related classes

How to test

  1. Open the Start Page (click File > Start Page)
  2. Click on the GitHub button which is under Open
  3. Clone a repository
  4. Delete the repository folder (necessary to make the URL link appear)
  5. Open the Start Page (click File > Start Page)
  6. Click on the https:// link to the repository you cloned then deleted
  7. Open from GitHub dialog should appear

Fixes #2199

@jcansdale
Use modern clone/open dialog when re-cloning
1da1d9f 
Use the same open/clone dialog when cloning or re-cloning a respository
repository that has been cloned before.
@jcansdale
Remove obsolete ReCloneDialog
818b02e
@jcansdale jcansdale changed the base branch from master to fixes/2196-clone-progress January 28, 2019 12:51
@jcansdale jcansdale changed the base branch from fixes/2196-clone-progress to master January 28, 2019 12:52
@jcansdale
Copy link
Collaborator Author

jcansdale commented Jan 28, 2019 •
edited
Loading

@prasethu I'm trying to test this PR, but the cloned URLs don't appear on the Start Page history (step 5 above). Any idea what's going on or why they might not be appearing? 😕

I was always unsure about when they were supposed to appear. I'd like to understand what's going on now so we can test it properly.

Update: I see the URL link appears when you delete the repository folder. It all makes sense now! 🙂

grokys
grokys approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing code!

@jcansdale jcansdale merged commit a49e5de into master Jan 29, 2019
@jcansdale jcansdale deleted the fixes/2199-reclone-using-new-open-clone-dialog branch January 29, 2019 11:07
@jcansdale jcansdale mentioned this pull request Feb 11, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@prasethu prasethu Awaiting requested review from prasethu

@meaghanlewis meaghanlewis Awaiting requested review from meaghanlewis

1 more reviewer

@grokys grokys grokys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcansdale @grokys
Morty Proxy This is a proxified and sanitized view of the page, visit original site.