This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Update inline review / annotation margin glyph #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the glyph used in the diff margins for inline reviews and annotations:
I swapped out the 馃挰 icon with a more generic 馃敼icon since I wanted to mark that there was some sort of feedback left on this line, but not specific as to what it is. I'm assuming that going this route means we won't need to introduce new logic to showing and swapping out different types of indicators. I think in a future iteration, we can figure out ways to represent the types of feedback / annotations left on a line.
Before
Indication for comments left on a line:
Indication for annotations left on a line:
After
Indication for comments left on a line:
Indication for annotations left on a line:
