Fix GitGitGadget's open PRs -> cover letter Message-ID map#70
Merged
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Jan 17, 2019
Merged
Fix GitGitGadget's open PRs -> cover letter Message-ID map#70dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
By mistake, the Message-ID was left empty. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
To clarify: the current GitGitGadget options contains: "openPRs": {
"https://github.com/gitgitgadget/git/pull/100": "pull.100.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/101": "",
"https://github.com/gitgitgadget/git/pull/103": "",
"https://github.com/gitgitgadget/git/pull/104": "",
"https://github.com/gitgitgadget/git/pull/105": "",
"https://github.com/gitgitgadget/git/pull/106": "",
"https://github.com/gitgitgadget/git/pull/107": "",
"https://github.com/gitgitgadget/git/pull/15": "pull.15.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/24": "",
"https://github.com/gitgitgadget/git/pull/29": "pull.29.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/31": "pull.31.v2.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/50": "pull.50.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/59": "pull.59.v2.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/66": "pull.66.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/82": "pull.82.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/83": "pull.83.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/87": "pull.87.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/89": "pull.89.v3.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/90": "pull.90.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/92": "",
"https://github.com/gitgitgadget/git/pull/95": "pull.95.git.gitgitgadget@gmail.com",
"https://github.com/gitgitgadget/git/pull/96": "pull.96.git.gitgitgadget@gmail.com"
}Clearly, some newer entries lack the Message-ID of the corresponding cover letter. This PR is intended to fix that for future submissions. |
Member
Author
|
@derrickstolee could you have a look? |
derrickstolee
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By mistake, the Message-ID was left empty.