ci: upgrade to node.js v10.x#64
Merged
derrickstolee merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Dec 26, 2018
dscho:upgrade-to-node.js-v10.xdscho/gitgitgadget:upgrade-to-node.js-v10.xCopy head branch name to clipboard
Merged
ci: upgrade to node.js v10.x#64derrickstolee merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom dscho:upgrade-to-node.js-v10.xdscho/gitgitgadget:upgrade-to-node.js-v10.xCopy head branch name to clipboard
derrickstolee merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
dscho:upgrade-to-node.js-v10.xdscho/gitgitgadget:upgrade-to-node.js-v10.xCopy head branch name to clipboard
Conversation
In theory, the (very simple) GitGitGadget code should compile easily with any node.js version that supports ES6. In practice, only a proper test suite can give us enough confidence that that is the case. Luckily, even GitGitGadget's rather sparse test suite covers enough to give us that confidence, and we should be able to upgrade to node.js v10.x without issues (because v8.x is expected to not receive any regular updates anymore come April '19, and not even security updates come December '19). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
derrickstolee
approved these changes
Dec 26, 2018
Member
Author
|
Whoa, that was fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In theory, the (very simple) GitGitGadget code should compile easily
with any node.js version that supports ES6. In practice, only a proper
test suite can give us enough confidence that that is the case.
Luckily, even GitGitGadget's rather sparse test suite covers enough to
give us that confidence, and we should be able to upgrade to node.js
v10.x without issues (because v8.x is expected to not receive any
regular updates anymore come April '19, and not even security updates
come December '19).
This addresses part of #63.