Bu-bye Probot#60
Merged
derrickstolee merged 6 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Dec 26, 2018
Merged
Bu-bye Probot#60derrickstolee merged 6 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
derrickstolee merged 6 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
We no longer use a Probot-based setup, but instead an Azure Function that in turn triggers an Azure Pipeline. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
A lot of them have been addressed already, or became obsolete. We should probably move those TODOs into GitHub issues... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Currently, we use @octokit/rest's classes, but we only have it as an indirect dependency via probot. This is not only fragile, it also needs to be fixed because we are about to remove the latter dependency (GitGitGadget is no longer based on Probot). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We are no longer using Probot... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…ed app Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
It no longer applies. While at it, mention scripts/. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
derrickstolee
approved these changes
Dec 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GitGitGadget is no longer a web app, but rather a serverless Azure Function that triggers a dedicated Azure Pipeline (making it much faster in the process, not to mention the nice PR Check that lets users even see the logs), we no longer need Probot.