Use correctly-encoded email headers for names with non-ASCII characters#54
Merged
derrickstolee merged 3 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Dec 26, 2018
Merged
Use correctly-encoded email headers for names with non-ASCII characters#54derrickstolee merged 3 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
derrickstolee merged 3 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
Apparently, VS Code's internal formatting interferes with TSLint's (resulting in the formatting seemingly reverting and then re-reverting within half a second upon save). So let's disable VS Code's. While at it, also define the alignment rules. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
... according to the new rules. This (huge) commit best viewed with --color-words. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
Please note that this PR is based on #53, so that one should be merged first. |
When sending mails, the From: or Cc: headers can only contain ASCII characters. Any non-ASCII characters need to be encoded, otherwise the emails will be rejected by the Git mailing list. With this change, the test now also finally learns to test inserting Cc: lines in the GitGitGadget mode (rather than testing the non-GitGitGadget one). This fixes gitgitgadget#29 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
@slavicaDj this PR, once merged, should unblock you. |
Member
Author
There you go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue a couple times when Cc:ing Ævar: if the Cc: header contains unencoded non-ASCII characters, the Git mailing list will simply reject that mail.
So let's encode those characters (using nodemailer's internal
encodeWords()function).This fixes #29.